Remove unnecessary Guice dependencies [tp-tests] #3852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not sure why we needed these dependencies but it seems like we don't them any more. They were added as part of an update to a newer TinkerPop version so maybe we needed those entries simply to avoid dependency convergence errors: JanusGraph@ae07bbd Signed-off-by: Florian Hockmann <[email protected]>
This was referenced Jun 23, 2023
farodin91
approved these changes
Jun 23, 2023
porunov
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure why we needed these dependencies but it seems like we don't need them any more.
They were added as part of an update to a newer TinkerPop version so maybe we needed those entries simply to avoid dependency convergence errors:
ae07bbd