-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning: componentWillReceiveProps has been renamed #166
Conversation
Replacing use of deprecated lifecycle method
adding newly built files
This will make the lib incompatible with React 15.0 - 16.2. Better to just rename to UNSAFE_componentWillReceiveProps for now. |
fair |
Sorry, noob question. Why does it matter that replacing depreciated lifecycle methods make it incompatible with React 15.0 - 16.2 if older versions of this component are still available? Thanks! |
Because the incompatibility with React 15.0 - 16.2 would be a breaking change, semantic versioning would require incrementing the major version of this package. Libraries that depend on this one, like react-select, would then not get the upgrade by default, and would have to also bump their major versions if they manually took the upgrade. It's preferable to let everyone get the immediate benefit of the console spam going away without having to go through all that. |
So these types of breaking changes should only be performed when the major version is increased? Then the question becomes why wasn't there a major version change due to react's change. Seems like a tricky balance in keeping up to date with the latest changes and compatibility with other modules. Thanks for your input! |
I'm getting this error and I'm assuming its relevant to this thread.
What type of work would require a compatible change? |
JedWatson/react-select#3715
JedWatson/react-select#3487
JedWatson/react-select#3720
#164
#163
JedWatson/react-select#3773
JedWatson/react-select#3770