Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marked deprecated react lifecycles as UNSAFE_* #3716

Merged
merged 1 commit into from
Aug 18, 2019

Conversation

rj-david
Copy link
Contributor

As a quick fix to remove the warnings starting react 16.9.0, this marked the deprecated react lifecycles as UNSAFE_*

(Note that this is just to remove the warning. There is still a need to refactor this code to move the code from the deprecated lifecycles to the correct lifecycles - and maybe change some logic)

@DougPuchalski
Copy link

Please merge this. These warnings have been around for ages, and they mask real ones that need attention.

@elstob
Copy link

elstob commented Aug 13, 2019

@JedWatson Would be great to have this one merged.

@elstob
Copy link

elstob commented Aug 18, 2019

@jossmac - You seem to be the last active dev on this repo of late. Is there any chance we can get this PR merged in please?

@rj-david
Copy link
Contributor Author

Also tagging @gwyneplaine as this seems affecting a lot of developers now

@gwyneplaine
Copy link
Collaborator

@rj-david this looks good, thanks for doing this 👌

@gwyneplaine gwyneplaine merged commit 97fbd4c into JedWatson:master Aug 18, 2019
@elstob
Copy link

elstob commented Aug 23, 2019

Thank you @gwyneplaine !

@mvestergaard
Copy link

mvestergaard commented Sep 9, 2019

I'm sorry, but I can't help but feel that this is the wrong approach.
Now the deprecated methods are deliberately being used. What happens when react 17.0 rolls around? This will be long forgotten, and you'll be bombarded with bug reports because you are calling methods that don't exist.

Instead these method calls should be replaced with the newer recommended way of doing things.

What is going on with this project? Is it even actively maintained? Simple things like this take ages to get patched.

@rj-david
Copy link
Contributor Author

rj-david commented Sep 9, 2019

@mvestergaard, feel free to do the right approach and submit the PR. I'm fully supporting that move

@ranneyd
Copy link

ranneyd commented Sep 19, 2019

@gwyneplaine can we make a release for this?

@ranneyd
Copy link

ranneyd commented Sep 20, 2019

@JedWatson @jossmac can we get an NPM release for this? All these people will be grateful:

#3720

@jossmac
Copy link
Collaborator

jossmac commented Sep 20, 2019

@elstob @ranneyd I don't have publishing permission.

@saboya
Copy link

saboya commented Sep 20, 2019

@rj-david @gwyneplaine There's a 6-month old open PR for the proper fix for this: #3487

@rj-david
Copy link
Contributor Author

@saboya fantastic. Will check it once I get the chance.

We now have a couple of options:

  • my PR and keep dependencies the same
  • saboya's PR and adjust react's min dependency

@gwyneplaine
Copy link
Collaborator

apologies for the delay everyone, this has now been published as part of 3.0.5
@saboya I'll have a look at this PR and get it in as soon as I can

@ranneyd
Copy link

ranneyd commented Sep 20, 2019

@gwyneplaine the lib still has this problem:

#3487

https://github.com/JedWatson/react-input-autosize needs to be fixed too

@ranneyd
Copy link

ranneyd commented Sep 23, 2019

@youluna
Copy link

youluna commented Oct 22, 2019

UNSAFE_ aliases were added to React in 16.3.0, is there any other prs to make the lib compatible with React 16.0.0 - 16.2.x ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants