Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in StateManagerProps>Option docs #4406

Merged
merged 2 commits into from
Feb 6, 2021

Conversation

Reflex-Gravity
Copy link
Contributor

This PR consists of a fix for a typo for Type under docs for StateManagerProps > Option.
Below is the screenshot of the typo.

react-select-issue-Screenshot_2021-01-27_15-24-18

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2021

⚠️ No Changeset found

Latest commit: 289d4c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Reflex-Gravity Reflex-Gravity changed the title Fixed typo in Option docs Fixed typo in StateManagerProps>Option docs Jan 27, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 27, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 289d4c1:

Sandbox Source
react-codesandboxer-example Configuration

@ebonow ebonow added the category/documentation Issues or PRs about documentation or the website itself label Feb 2, 2021
@ebonow ebonow added this to the 4.1 milestone Feb 2, 2021
Comment on lines +34 to +35
/** Type is used by the menu to determine whether this is an option or a group.
In the case of option this is always `option`. **/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this conform with official JSDoc.

Suggested change
/** Type is used by the menu to determine whether this is an option or a group.
In the case of option this is always `option`. **/
/**
* Type is used by the menu to determine whether this is an option or a group.
* In the case of option this is always `option`.
*/

@Methuselah96 Methuselah96 dismissed their stale review February 6, 2021 23:34

We can clean this up later.

@Methuselah96 Methuselah96 merged commit b41ba23 into JedWatson:master Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/documentation Issues or PRs about documentation or the website itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants