Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo in StateManagerProps>Option docs #4406

Merged
merged 2 commits into from
Feb 6, 2021
Merged

Fixed typo in StateManagerProps>Option docs #4406

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c0199c
Fixed typo in Option docs
Jan 27, 2021
289d4c1
Merge branch 'master' into master
Methuselah96 Feb 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-select/src/components/Option.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ export type OptionProps = PropsWithStyles &
innerProps: InnerProps,
/* Text to be displayed representing the option. */
label: string,
/* Type is used by the menu to determine whether this is an option or a group.
In the case of option this is always `option`. */
/** Type is used by the menu to determine whether this is an option or a group.
In the case of option this is always `option`. **/
Comment on lines +34 to +35
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this conform with official JSDoc.

Suggested change
/** Type is used by the menu to determine whether this is an option or a group.
In the case of option this is always `option`. **/
/**
* Type is used by the menu to determine whether this is an option or a group.
* In the case of option this is always `option`.
*/

type: 'option',
/* The data of the selected option. */
data: any,
Expand Down