Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ana_2p2 output directory control #94

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Sep 2, 2023

  • add new argument outputDir to ana_2p2.java to allow custom output directories
  • refactor detector classes in monitoring/ to use outputDir
    • their main methods default to plots[RUNNUM] (or plots if run 0), avoiding breaking anything that calls them; a separate PR could be made if output control is needed at that level
  • proposed for merging into refactor!: unify wrappers and output files for workflow automation #73, but this will be a breaking change
  • hard-coded /volatile directories are removed; use the new outputDir arguments if output to /volatile is desired

@c-dilks c-dilks merged commit e8fe3c4 into clean-slurm-mon12 Sep 22, 2023
5 of 6 checks passed
@c-dilks c-dilks deleted the monitoring-outputDir branch September 22, 2023 20:18
@c-dilks c-dilks restored the monitoring-outputDir branch September 22, 2023 20:33
@c-dilks c-dilks deleted the monitoring-outputDir branch September 22, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant