Support configurable vertical centering via LineHeightStyle.Alignment
#1569
+499
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 16, 2024
MatkovIvan
changed the title
LineHeightStyle.Alignment
MatkovIvan
added a commit
to JetBrains/skiko
that referenced
this pull request
Sep 18, 2024
Support configurable vertical centering for implementing Compose's `LineHeightStyle.Alignment`. https://youtrack.jetbrains.com/issue/CMP-2602 See also: - JetBrains/skia#5 - JetBrains/compose-multiplatform-core#1569
MatkovIvan
force-pushed
the
ivan.matkov/text-v-center
branch
from
4db9062
to
32c04b7
Compare
eymar
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
LGTM!
Do we need to automate the tests for this change to not miss regressions?
I guess the only way to automate the tests for this is screenshot tests with a hardcoded font (loaded from resources).
Perhaps 1 big test (screenshot) with 4x4 variants like in your demo would work.
|
Screenshot tests for text/font is a separate story, that we should definitely handle. But I believe that such setup is out of the scope of this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JetBrains/compose-multiplatform#2602 (CMP-2602)
Testing
Added a sample page into mpp demo
This should be tested by QA
Release Notes
Features - Multiple Platforms
LineHeightStyle.Alignment