Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support top ratio based vertical alignment #5

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Support top ratio based vertical alignment #5

merged 3 commits into from
Sep 17, 2024

Conversation

MatkovIvan
Copy link
Member

@MatkovIvan MatkovIvan commented Sep 13, 2024 •
edited
Loading

@igordmn
Copy link
Collaborator

igordmn commented Sep 13, 2024 •
edited
Loading

Is this ready for review? Or is it needed a preliminary draft review?

@MatkovIvan
Copy link
Member Author

WIP: testing
The code itself is ready for review

@igordmn
Copy link
Collaborator

igordmn commented Sep 13, 2024 •
edited
Loading

WIP: testing

Ok, I'll review it after testing :). Testing discovers new bugs and the code changes.

@MatkovIvan MatkovIvan mentioned this pull request Sep 16, 2024
Merged
@MatkovIvan MatkovIvan marked this pull request as ready for review September 16, 2024 18:18
eymar
eymar reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@eymar eymar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might worth to add a test in skiko to set the topRatio, get it and check the line metrics.

modules/skparagraph/src/ParagraphCache.cpp Show resolved Hide resolved
modules/skparagraph/src/ParagraphCache.cpp Show resolved Hide resolved
@MatkovIvan MatkovIvan merged commit d2aaacc into skiko Sep 17, 2024
@MatkovIvan MatkovIvan deleted the ivan.matkov/line-topratio branch September 17, 2024 13:20
@MatkovIvan MatkovIvan mentioned this pull request Sep 17, 2024
Merged
MatkovIvan added a commit to JetBrains/skiko that referenced this pull request Sep 18, 2024
@MatkovIvan
Replace half leading to top ratio (#989)
355ede9 
Support configurable vertical centering for implementing Compose's
`LineHeightStyle.Alignment`.

https://youtrack.jetbrains.com/issue/CMP-2602

See also:
- JetBrains/skia#5
- JetBrains/compose-multiplatform-core#1569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eymar eymar eymar approved these changes

@igordmn igordmn Awaiting requested review from igordmn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatkovIvan @igordmn @eymar