Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 2D / 3D dimensionality split #435

Open
Tracked by #433
janhohenheim opened this issue Jul 17, 2024 · 0 comments
Open
Tracked by #433

Remove 2D / 3D dimensionality split #435

janhohenheim opened this issue Jul 17, 2024 · 0 comments
Labels
2D Specific to two dimensions 3D Specific to three dimensions C-Enhancement New feature or request C-Usability A quality-of-life improvement that makes Avian easier to use D-Complex Challenging from a design or technical perspective. Ask for help if you'd like to help tackle this! X-Controversial There is active debate or serious implications around merging this PR

Comments

@janhohenheim
Copy link
Contributor

janhohenheim commented Jul 17, 2024

Quoting @Jondolf

Context

Yes, this is something I want to try. I already have an old local branch with an initial attempt at unifying the crates, although it's old enough that I'd need to start that from scratch.
It's not only about Parry since we could still use parry2d and parry3d simultaneously. It's mostly just that supporting both 2D and 3D with a single crate requires a heck of a lot of duplication, and/or a bunch of generics for the internals


Context

Then there's the dimension split for 2D and 3D with the rather dubious crate structure; I'm not sure if it's something Bevy would accept in-tree, and it also makes games combining 2D and 3D physics more annoying

@Jondolf Jondolf added 2D Specific to two dimensions 3D Specific to three dimensions X-Controversial There is active debate or serious implications around merging this PR C-Usability A quality-of-life improvement that makes Avian easier to use D-Complex Challenging from a design or technical perspective. Ask for help if you'd like to help tackle this! C-Enhancement New feature or request labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2D Specific to two dimensions 3D Specific to three dimensions C-Enhancement New feature or request C-Usability A quality-of-life improvement that makes Avian easier to use D-Complex Challenging from a design or technical perspective. Ask for help if you'd like to help tackle this! X-Controversial There is active debate or serious implications around merging this PR
Projects
None yet
Development

No branches or pull requests

2 participants