Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting missingstrings=["NA"] makes some columns not have names #530

Closed
xiaodaigh opened this issue Nov 16, 2019 · 1 comment · Fixed by #535
Closed

Setting missingstrings=["NA"] makes some columns not have names #530

xiaodaigh opened this issue Nov 16, 2019 · 1 comment · Fixed by #535

Comments

@xiaodaigh
Copy link
Contributor

Consider a csv strucutred liked this

,column2
NA,2
2,3

nocolumn1name = CSV.read("c:/data/plsdel.csv", missingstrings=["NA"])
hascolumn1name = CSV.read("c:/data/plsdel.csv")

The top one has no column name for column1 but the 2nd way has.

See
image
quinnj added a commit that referenced this issue Nov 20, 2019
@quinnj
If a parsed column name is empty (i.e. zero length), then generate a …
1cb7ea3 
…column name. Fixes #530
@quinnj quinnj mentioned this issue Nov 20, 2019
Merged
@quinnj
Copy link
Member

quinnj commented Nov 20, 2019

Thanks for the report @xiaodaigh; fix is up here: #535

quinnj added a commit that referenced this issue Nov 20, 2019
@quinnj
If a parsed column name is empty (i.e. zero length), then generate a …
4b3ac7d 
…column name. Fixes #530 (#535)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

If a parsed column name is empty (i.e. zero length), then generate a … JuliaData/CSV.jl
2 participants
@quinnj @xiaodaigh