Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a parsed column name is empty (i.e. zero length), then generate a … #535

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Nov 20, 2019

…column name. Fixes #530

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@e95bbe7). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #535   +/-   ##
=========================================
  Coverage          ?   82.83%           
=========================================
  Files             ?        7           
  Lines             ?     1439           
  Branches          ?        0           
=========================================
  Hits              ?     1192           
  Misses            ?      247           
  Partials          ?        0
Impacted Files Coverage Δ
src/detection.jl 88.76% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e95bbe7...1cb7ea3. Read the comment docs.

@quinnj quinnj merged commit 4b3ac7d into master Nov 20, 2019
@quinnj quinnj deleted the jq/530 branch November 20, 2019 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting missingstrings=["NA"] makes some columns not have names
1 participant