Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower byval ourselves for PTX. #93

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Lower byval ourselves for PTX. #93

merged 1 commit into from
Jan 14, 2021

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Oct 7, 2020

Works around #92.

@maleadt
Copy link
Member Author

maleadt commented Oct 7, 2020

Oh no: https://gitlab.com/JuliaGPU/GPUCompiler.jl/-/jobs/777529826
JuliaGPU/CUDAnative.jl#4 somehow coming back to bite me 😠

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #93 (18baa2a) into master (7f5cf89) will increase coverage by 1.85%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   82.44%   84.30%   +1.85%     
==========================================
  Files          22       22              
  Lines        1555     1529      -26     
==========================================
+ Hits         1282     1289       +7     
+ Misses        273      240      -33     
Impacted Files Coverage Δ
src/ptx.jl 98.57% <100.00%> (-0.03%) ⬇️
src/rtlib.jl 92.55% <0.00%> (+0.97%) ⬆️
src/jlgen.jl 82.40% <0.00%> (+3.64%) ⬆️
src/irgen.jl 95.63% <0.00%> (+4.00%) ⬆️
src/interface.jl 75.00% <0.00%> (+5.00%) ⬆️
src/runtime.jl 51.78% <0.00%> (+6.47%) ⬆️
src/spirv.jl 94.17% <0.00%> (+7.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f5cf89...18baa2a. Read the comment docs.

src/ptx.jl Outdated Show resolved Hide resolved
@maleadt
Copy link
Member Author

maleadt commented Jan 14, 2021

Let's test this with CUDA.jl.

@maleadt maleadt merged commit 18e5c07 into master Jan 14, 2021
@maleadt maleadt deleted the tb/ptx_nobyval branch January 14, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants