This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Preserve GValues from GC (fixes #581) #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a consequence of the forced specialization on the `RT` argument of `signal_emit` in #552, the compiler now knows whether `RT === Nothing`. In that case, it also knows that `return_value` will not be used, so it is free to be garbage-collected. When that happens, it triggers segfaults. This puts both potential `GValue`-arguments inside a `GC.@preserve` to prevent garbage collection. Fixes #581.
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
==========================================
+ Coverage 48.60% 48.66% +0.05%
==========================================
Files 32 32
Lines 2660 2661 +1
==========================================
+ Hits 1293 1295 +2
+ Misses 1367 1366 -1
Continue to review full report at Codecov.
|
|
I ran the tests 20 more times and never got a segfault. I think we can safely say this fixes the problem that has been holding back GtkObservables. |
|
then go ahead and press the button + release. It certainly does not hurt to prevent GC to collect that value during that call. |
This was referenced Dec 14, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a consequence of the forced specialization on the
RTargumentof
signal_emitin #552, the compiler now knows whetherRT === Nothing. In that case, it also knows thatreturn_valuewill not be used, so it is free to be garbage-collected.When that happens, it triggers segfaults. EDIT: actually, that can't
be correct, because it doesn't create them when
RT===Nothing.So probably #552 didn't trigger this.
This puts both potential
GValue-arguments inside aGC.@preserveto prevent garbage collection. Fixes #581.
A reproducer of the crash is with GtkObservables:
/some/path/GtkObservables$ julia --check-bounds=yes --color=yes --depwarn=yes --inline=yes --project=@. -e 'import Pkg; Pkg.test(; coverage=true)'but that is obviously difficult to convert into a test. I've run it 5 times locally and have yet to see a crash, which did not happen before this commit.