Add paging by thread (and task, optionally)

[IanButterworth]

Depends on

• julia 1.8
• Add option to specify threads and tasks on 1.8 FlameGraphs.jl#44
• Automatic event loop start/stop when not showing anything JuliaGraphics/Gtk.jl#607

julia> using ProfileView

julia> function myfunc()
                  A = rand(400, 400, 400)
                  maximum(A)
              end
myfunc (generic function with 1 method)

julia> myfunc();

julia> @profview myfunc()

[timholy]

(Not real ones, anyway. I should fix that at some point, but probably not until #169.)

[timholy]

Now there are tests!

[timholy]

Anything here likely to be breaking? Otherwise 1.0 is ready to go.

[IanButterworth]

I don't think so. It just needs code branches depending on julia version >= 1.8 (or detecting if profile metadata is present, perhaps).
I could try to get this done over the weekend, if that's ok?

[timholy]

If it's non-breaking, there's no urgency. If it is, I'll wait. I'm pretty happy using master for a while.

So, 🤷 Just let me know what you want me to do, and don't distort your schedule to rush this out. I'll be starting holiday travel around the weekend anyway.

[IanButterworth]

I think it can be done without breaking, so don't let this stop 1.0

[timholy]

OK, I'll get it out. That will shake out any remaining bugs in GtkObservables/Gtk. The landmark change was a whopping two lines: JuliaGraphics/Gtk.jl#600. The rest has been finishing WIP and merging it. But of course wider usage often turns up other issues, and I might as well see what that shakes out.

[IanButterworth]

(just a rebase at this stage)

[IanButterworth]

@timholy what do you think the save/open buttons should do once thread paging is added? I'm thinking it should save/open all pages?

[IanButterworth]

Ok, this is passing locally for me with timholy/FlameGraphs.jl#44 now

I originally wanted to make the load/save buttons work on all pages at once, but figuring that out was stalling this.. perhaps that could be a future PR?

With this PR each page has its own load/save buttons.

For julia <1.8 or if metadata is removed, a single tab shows labeled as "all threads" which I think is informative so worth keeping.

[IanButterworth]

When testing this I suggest using this workaround JuliaLang/julia#35552 (comment)

[codecov]

Codecov Report

Merging #176 (55f2857) into master (1e91348) will decrease coverage by 1.10%.
The diff coverage is 81.57%.

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   80.92%   79.82%   -1.11%     
==========================================
  Files           2        2              
  Lines         173      228      +55     
==========================================
+ Hits          140      182      +42     
- Misses         33       46      +13     

Impacted Files	Coverage Δ
src/precompile.jl	0.00% <0.00%> (ø)
src/ProfileView.jl	87.08% <83.78%> (-3.25%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e91348...55f2857. Read the comment docs.

[IanButterworth]

I think this is ready. I'll merge and release 1.1.0

[timholy]

This looks beautiful! I will be excited to try it out.

[timholy]

Looks like we could use a test with expand_tasks = true?