Fix rename by removing has exported binding to haskey #694
Conversation
musm
force-pushed
the
has
branch
3 times, most recently
from
96a9bf3
to
d403f78
Compare
|
Updated. I kinda dont' get the purpose of |
test/runtests.jl
Outdated
| @@ -4,6 +4,23 @@ using Pkg | |||
|
|
|||
| println("HDF5 version ", HDF5.h5_get_libversion()) | |||
|
|
|||
| # Copied over from JuliaLang/Test | |||
There was a problem hiding this comment.
Why copy this? As far as I can tell, Test has exported GenericString since v0.5:
$ grep -ne 'export.*GenericString' stdlib/Test/src/Test.jl
23:export GenericString, GenericSet, GenericDict, GenericArray, GenericOrder
$ git log --oneline --no-patch -L 23,23:stdlib/Test/src/Test.jl
744ead41cb fix maximum on generic orders (#30441)
66ef347631 Base.Test: add GenericArray type and use it in test/random.jl (#22790)
c6799e6437 enable rand(::Union{AbstractSet,Associative}) (#22228)
0a61406e5a GenericString: move into Base.Test and export; rm CharString.
$ contrib/commit-name.sh 0a61406e5a
0.5.0-dev+4653There was a problem hiding this comment.
Thanks, didn't realize it was exported
|
This will also need some updates to the docs: https://juliaio.github.io/HDF5.jl/dev/#Getting-information |
I'm guessing there's some internal library overhead which can be avoided if with the two-names version provided by |
This was changed in an old Julia commit and renamed to haskey.
Co-authored-by: jmert <[email protected]>
|
Many thanks for the review |
#694 deprecated exists, but that PR left it within the explicit export list so the deprecation binding still worked with the false final argument. Then in #701 it was removed from the main export list, so the deprecation itself needs to do the [implicit] export for the deprecation to be useful to downstream users. Fixes #721.
No description provided.