Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rename by removing has exported binding to haskey #694

Merged
merged 5 commits into from
Oct 10, 2020
Merged

Fix rename by removing has exported binding to haskey #694

merged 5 commits into from
Oct 10, 2020

Commits on Oct 10, 2020

  1. Remove exported has binding and rename it to haskey 

    This was changed in an old Julia commit and renamed to haskey.
    @musm
    musm committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    ba1769a View commit details
    Browse the repository at this point in the history

  2. Indexing using begin only available on 1.5

    @musm
    musm committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    7724977 View commit details
    Browse the repository at this point in the history

  3. Update plain.jl

    @musm
    musm committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    10c6b91 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: jmert <[email protected]>
    @musm @jmert
    musm and jmert committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    e94bdd6 View commit details
    Browse the repository at this point in the history

  5. review comments

    @musm
    musm committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    61a9a55 View commit details
    Browse the repository at this point in the history