-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect reader #191
Comments
@neveritt what do you think ? |
@blegat, I think you are right. There is another option which I think was my original intention. The Lines 287 to 292 in bae7008
I will create a test case that catches this error and try first the second approach and then your approach to solve this issue. In the meantime, @tanmaykm feel free to back my changes out and make a new release if you so wish. |
Fixed by #193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#188 broke https://github.com/pszufe/OpenStreetMapX.jl.
The issues seems to be that the reader chosen in
ProtoBuf.jl/src/codec.jl
Line 428 in bae7008
only depends on
jtyp
and not onattrib.ptyp
.However, if
jtyp
isInt64
for instance,ptyp
can either be:int64
or:sint64
or:sfixed64
.The line that is called is:
ProtoBuf.jl/src/codec.jl
Line 244 in bae7008
so it assumes that
ptyp
is always:int64
whenjtyp
isInt64
.Instead, at:
ProtoBuf.jl/src/codec.jl
Line 504 in bae7008
attrib.jtyp
should be replaced byInt64
,FixedSizeNumber{Int64}
orSignedNumber{Int64}
depending onattrib.ptyp
.The same probably also applies for the lines:
ProtoBuf.jl/src/codec.jl
Lines 466 to 469 in bae7008
The text was updated successfully, but these errors were encountered: