Make wiretypes into julia types and specialize methods on these types #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the need for the
WIRETYPES
lookup table by specializing the lookup based on Julia types instead.The lookup table is replace by
wire_type
,_read_value
and_write_value
functions.This has a significant performance improvement for writing, but does not seem affect reading.
For example:
compared to
in the previous version.
In order to achieve the specialization for the types that has several serializations, e.g. (
int64
,sint64
,sfixed64
)two types
SignedNumber
andFixedSizeNumber
are introduced to carry extra information about serialization.I had to rearrange some methods to make the dispatch work properly, which may make the PR a bit hard to read.