fix incorrect serialization of some concrete types #193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #191.
Changes
FixedSizeNumber
orSignedNumber
are now handled correctly in bothreadproto
and writeprotoby converting based on
attrib.ptyp`.attrib.ptyp
to the corresponding Julia type.Int64
,SignedNumber{Int64}
...) and arrays of concrete types.A minor fix of conversions of
FixedSizeNumber
andSignedNumber
is also in this PR.Notes
Note that the meta for dictionaries seem not to support
FixedSizeNumber
orSignedNumber
ProtoBuf.jl/src/codec.jl
Line 571 in 0428aee
due to
mapentry_meta
being called with the julia type as argument, and only use that to setProtoMetaAttribs
, an issue that predates the issue introduced in #188.Because of that I have not added tests for
maps
but I tried to ensure thatreadproto
andwriteproto
can handle those cases onceProtoMetaAttribs
is set correctly.