Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect fixed/signed definition in proto #197

Closed
wants to merge 1 commit into from

Conversation

findmyway
Copy link
Contributor

This should fix #196

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #197 (b05d788) into master (a0a8396) will increase coverage by 1.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   67.95%   69.14%   +1.18%     
==========================================
  Files          19       19              
  Lines        2684     2700      +16     
==========================================
+ Hits         1824     1867      +43     
+ Misses        860      833      -27     
Impacted Files Coverage Δ
src/codec.jl 94.48% <100.00%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0a8396...b05d788. Read the comment docs.

@findmyway
Copy link
Contributor Author

Oh, no... I just find there's already an opening PR #193 which tried to address the same issue. 😭😭😭

Gently ping @tanmaykm . Could you help to review both PR?

The solution in #193 is to update attrib.ptyp directly and mine here is just a workaround (but should be much easier to review and merge 😆 ).

(Also cc @neveritt)

@tanmaykm
Copy link
Member

Thanks @findmyway !
I just merged #193. Hope that works for you too. Shall tag a new release in a bit.
Sorry for the delay.

@findmyway
Copy link
Contributor Author

Thanks!

@findmyway findmyway closed this Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wire_type seems to be incorrectly used in writeproto?
2 participants