Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.10] Fix the trailing task warning on lazy artifacts #3950

Merged
merged 2 commits into from
Jul 13, 2024
Merged

[release-1.10] Fix the trailing task warning on lazy artifacts #3950

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e237fd
fix trailing downloads task
IanButterworth Jul 13, 2024
a297995
Update src/PlatformEngines.jl
IanButterworth Jul 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/PlatformEngines.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,8 +281,16 @@ function download(
else
(total, now) -> nothing
end
# During precompilation don't use the default downloader as it has a
# 30s grace period that will cause the pending process warning on 1.10
# (on 1.11 the downloader is finalized before the pending process detector)
downloader = if ccall(:jl_generating_output, Cint, ()) != 0
Downloads.Downloader(grace=0)
else
nothing
end
try
Downloads.download(url, dest; headers, progress)
Downloads.download(url, dest; headers, progress, downloader)
finally
do_fancy && end_progress(io, bar)
end
Expand Down
Loading