Skip to content

Commit

Permalink
Init codegen during sysimg restore (#41676)
Browse files Browse the repository at this point in the history
  • Loading branch information
maleadt authored Jul 27, 2021
1 parent 8ece865 commit 2fbeef8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/init.c
Original file line number Diff line number Diff line change
Expand Up @@ -734,12 +734,13 @@ JL_DLLEXPORT void julia_init(JL_IMAGE_SEARCH rel)
if (jl_options.cpu_target == NULL)
jl_options.cpu_target = "native";

if (jl_options.image_file)
if (jl_options.image_file) {
jl_restore_system_image(jl_options.image_file);
else
} else {
jl_init_types();
jl_init_codegen();
}

jl_init_codegen();
jl_init_common_symbols();
jl_init_flisp();
jl_init_serializer();
Expand Down
1 change: 1 addition & 0 deletions src/staticdata.c
Original file line number Diff line number Diff line change
Expand Up @@ -1839,6 +1839,7 @@ static void jl_restore_system_image_from_stream(ios_t *f) JL_GC_DISABLED
}

s.s = &sysimg;
jl_init_codegen();
jl_update_all_fptrs(&s); // fptr relocs and registration
// reinit ccallables, which require codegen to be initialized
s.s = f;
Expand Down

4 comments on commit 2fbeef8

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@vtjnash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @christopher-dG

Please sign in to comment.