Init codegen during sysimg restore. #41676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
approved these changes
Jul 22, 2021
|
The state of the sysimg is still indeterminate at this point. You cannot access it externally (in codegen) until it is finished. |
|
Ok, is there a way we can split up |
|
init_codegen is fine (it is pretty much free of external state), the |
|
What state hasn't been set up at that point? |
82 tasks
|
@vtjnash Care to elaborate? How else would you propose fixing this, try to make |
|
Jeff pointed out offline that this is happening after deserialize, but that it is just poorly named |
|
OK, thanks! |
KristofferC
pushed a commit
that referenced
this pull request
Aug 2, 2021
(cherry picked from commit 2fbeef8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41670. Restores the old order of jl_init->jl_load_sysimg->jl_init_codegen, which was changed in https://github.com/JuliaLang/julia/pull/40715/files#diff-0e5a5cdf744ddbc1c815bf0a767bc9988e37d88792e8acc95c7ed9863491f2afL1797, because deserializing a system image might require the code generator to be initialized (deserializing ccallables calls jl_compile_extern_c).