Revert "Use norm instead of abs in generic lu factorization (#34575)" (…

…#36096) This reverts commit ecc0c43. (cherry picked from commit be2c643)
JuliaLang · Jun 4, 2020 · 99adb51 · 99adb51
1 parent c7476af
commit 99adb51
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/stdlib/LinearAlgebra/src/lu.jl b/stdlib/LinearAlgebra/src/lu.jl
@@ -140,9 +140,9 @@ function generic_lufact!(A::StridedMatrix{T}, ::Val{Pivot} = Val(true);
             # find index max
             kp = k
             if Pivot
-                amax = norm(zero(T))
+                amax = abs(zero(T))
                 for i = k:m
-                    absi = norm(A[i,k])
+                    absi = abs(A[i,k])
                     if absi > amax
                         kp = i
                         amax = absi

diff --git a/stdlib/LinearAlgebra/test/generic.jl b/stdlib/LinearAlgebra/test/generic.jl
@@ -365,8 +365,6 @@ LinearAlgebra.Transpose(a::ModInt{n}) where {n} = transpose(a)
 
     # Needed for pivoting:
     Base.abs(a::ModInt{n}) where {n} = a
-    LinearAlgebra.norm(a::ModInt{n}) where {n} = a
-
     Base.:<(a::ModInt{n}, b::ModInt{n}) where {n} = a.k < b.k
 
     @test A*(lu(A, Val(true))\b) == b