Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use norm instead of abs in generic lu factorization #34575

Merged
merged 2 commits into from
Apr 24, 2020

Conversation

mschauer
Copy link
Contributor

Use norm instead of abs in generic lu factorization as discussed in #34574. The factorisation then works also with tensors represented by matrices with elements which are matrix like.

@andreasnoack andreasnoack added the linear algebra Linear algebra label Jan 29, 2020
@mschauer
Copy link
Contributor Author

mschauer commented Jan 30, 2020

This makes sense, but the fact that it broke test LinearAlgreba/generic because generic had a type without norm or iteratate defined suggest that one should see how it affects the registered packages.

@mschauer
Copy link
Contributor Author

Bump.

@andreasnoack andreasnoack merged commit ecc0c43 into JuliaLang:master Apr 24, 2020
mbauman added a commit that referenced this pull request Apr 28, 2020
* origin/master: (833 commits)
  Improve typesubtract for tuples (#35600)
  Make searchsorted*/findnext/findprev return values of keytype (#32978)
  fix buggy rand(RandomDevice(), Bool) (#35590)
  remove `Ref` allocation on task switch (#35606)
  Revert "partr: fix multiqueue resorting stability" (#35589)
  exclude types with free variables from `type_morespecific` (#35555)
  fix small typo in NEWS.md (#35611)
  enable inline allocation of structs with pointers (#34126)
  SparseArrays: Speed up right-division by diagonal matrices (#35533)
  Allow hashing 1D OffsetArrays
  NEWS item for introspection macros (#35594)
  Special case empty covec-diagonal-vec product (#35557)
  [GCChecker] fix a few tests by looking through casts
  Use norm instead of abs in generic lu factorization (#34575)
  [GCChecker,NFC] run clang-format -style=llvm
  [GCChecker] fix tests and add Makefile
  Add introspection macros support for dot syntax (#35522)
  Specialize `union` for `OneTo` (#35577)
  add pop!(vector, idx, [default]) (#35513)
  bump Pkg version (#35584)
  ...
andreasnoack added a commit that referenced this pull request Jun 1, 2020
KristofferC pushed a commit that referenced this pull request Jun 4, 2020
simeonschaub pushed a commit to simeonschaub/julia that referenced this pull request Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants