Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some signatures for chksquare and make the ... version type stable #12457

Merged
merged 1 commit into from
Aug 5, 2015

Conversation

andreasnoack
Copy link
Member

As pointed out by @KristofferC in #12452, there is a type stability problem with chksquare(Factorizations). E.g.

julia> Base.return_types(LinAlg.chksquare, (LinAlg.LU,))
1-element Array{Any,1}:
 Union{Array{Int64,1},Int64}

This is fixed by these changes.

@vtjnash
Copy link
Sponsor Member

vtjnash commented Aug 5, 2015

AppVeyor got confused (assigned two jobs the same number). AFAICT the build can not be restarted from here, so you'll have to force-push a new SHA1 hash if you want to trigger a new build.

(also Travis is having issues with their Mac cluster, so those are backed up right now too)

andreasnoack added a commit that referenced this pull request Aug 5, 2015
Remove some signatures for chksquare and make the ... version type stable
@andreasnoack andreasnoack merged commit 2171f80 into master Aug 5, 2015
@andreasnoack andreasnoack deleted the anj/chksquare branch August 5, 2015 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants