Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some signatures for chksquare and make the ... version type stable #12457

Merged
merged 1 commit into from
Aug 5, 2015
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions base/linalg.jl
Original file line number Diff line number Diff line change
Expand Up @@ -166,14 +166,14 @@ else
end

# Check that stride of matrix/vector is 1
function chkstride1(A::StridedVecOrMat...)
function chkstride1(A...)
for a in A
stride(a,1)== 1 || error("matrix does not have contiguous columns")
end
end

# Check that matrix is square
function chksquare(A::AbstractMatrix)
function chksquare(A)
m,n = size(A)
m == n || throw(DimensionMismatch("matrix is not square"))
m
Expand All @@ -185,7 +185,7 @@ function chksquare(A...)
size(a,1)==size(a,2) || throw(DimensionMismatch("matrix is not square: dimensions are $(size(a))"))
push!(sizes, size(a,1))
end
length(A)==1 ? sizes[1] : sizes
return sizes
end

# Check that upper/lower (for special matrices) is correctly specified
Expand Down