Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for 1.0.4 #30536

Closed
wants to merge 41 commits into from
Closed

Backports for 1.0.4 #30536

wants to merge 41 commits into from

Commits on Dec 30, 2018

  1. Use only safe axis types for Broadcast.combine_axes

    #30074 used the wrong notion of consistency since `OneTo(1)` is
    consistent (wrt broadcasting) with any range, but `OneTo` cannot
    handle `Slice(-1:1)`.
    
    (cherry picked from commit 1884cb4)
    timholy authored and KristofferC committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    160054e View commit details
    Browse the repository at this point in the history
  2. fix #30303, escaping $ when showing Symbols (#30304)

    * fix #30303, escaping $ when showing Symbols
    
    * use repr instead of escape_string
    
    (cherry picked from commit f0b9499)
    JeffBezanson authored and KristofferC committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    d9a3592 View commit details
    Browse the repository at this point in the history
  3. Use JL_AArch64_crc instead of HWCAP_CRC32 (#30324)

    Closes #26458
    
    (cherry picked from commit bd21aa7)
    staticfloat authored and KristofferC committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    7df523a View commit details
    Browse the repository at this point in the history
  4. @inbounds annotations for filter (#30156)

    (cherry picked from commit 58f9bf7)
    andyferris authored and KristofferC committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    52bf7b9 View commit details
    Browse the repository at this point in the history
  5. Expand and fix documentation of BitArray (#30340)

    Fixes #30337... and while I was there I added a bit more information about what BitArrays do and when you might run into them.
    
    (cherry picked from commit 0d62000)
    mbauman authored and KristofferC committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    2cadff3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e7187f6 View commit details
    Browse the repository at this point in the history
  7. fix bug with max_values in union! (#30315)

    (cherry picked from commit f49cb42)
    rfourquet authored and KristofferC committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    f4cd403 View commit details
    Browse the repository at this point in the history
  8. Force specialization on the type argument of _similar_for (#30331)

    (cherry picked from commit 891e2ab)
    martinholters authored and KristofferC committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    e2aebba View commit details
    Browse the repository at this point in the history
  9. added doc for AbstractChannel (#30347)

    (cherry picked from commit dda6450)
    matbesancon authored and KristofferC committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    43d99bb View commit details
    Browse the repository at this point in the history
  10. Copy editing in "Environment variables" docs (#30330)

    (cherry picked from commit 99b7b75)
    donm authored and KristofferC committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    43d1d9c View commit details
    Browse the repository at this point in the history
  11. [SparseArrays] Respect order of mul in (l)mul!(::Diagonal,::Sparse) (#…

    …30163)
    
    * order of mul in (l)mul!(::Diagonal,::Sparse)
    
    add tests for non-commutative mul
    
    * Create Quaternions.jl
    
    remove quaternions from generic tests
    
    (cherry picked from commit 3ee8798)
    dkarrasch authored and KristofferC committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    96f82b5 View commit details
    Browse the repository at this point in the history
  12. fix reinterpret for 0-dimensional arrays (#30376)

    (cherry picked from commit c379900)
    meggart authored and KristofferC committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    33f48cd View commit details
    Browse the repository at this point in the history
  13. stacktrace: prevent OOB-error in sysimage lookup (#30369)

    Previously, with a multi-versioned system image, there might be additional entries at the end of the clone list
    that do not correspond to an actual method (such as jlplt thunks).
    
    Also some code cleanup for clarity.
    
    fix #28648
    
    (cherry picked from commit e51a707)
    vtjnash authored and KristofferC committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    0ab6919 View commit details
    Browse the repository at this point in the history
  14. generalize sparse matrix slicing to integer types (#30319)

    (cherry picked from commit 072ad7d)
    dpo authored and KristofferC committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    3c9592d View commit details
    Browse the repository at this point in the history
  15. Base.worker_timeout() mention in manual (#30439)

    The manual mentions at https://docs.julialang.org/en/v1/manual/environment-variables/#JULIA_WORKER_TIMEOUT-1 a function Base.worker_timeout() but the implementation has instead only a function Distributed.worker_timeout()
    
    (cherry picked from commit 258e08a)
    mgkuhn authored and KristofferC committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    834503f View commit details
    Browse the repository at this point in the history
  16. Fix DimensionMismatch in SparseMatrixCSC assignment (#30507)

    Use _setindex! to fix DimensionMismatch in sparse assignment
    Fixes #28963
    
    (cherry picked from commit b73a746)
    raghav9-97 authored and KristofferC committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    ded25d3 View commit details
    Browse the repository at this point in the history
  17. faster mapfoldl for tuples (#30471)

    (cherry picked from commit 6dc205a)
    stevengj authored and KristofferC committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    0195be0 View commit details
    Browse the repository at this point in the history
  18. fix #30394, an unsoundness in ml_matches (#30396)

    This fixes a corner case where a bug is caused, counter-intuitively,
    by an over-estimated intersection.
    We have method signatures A and B, with A<B (A is a strict subtype).
    We have a dispatch tuple X, where X<:B and !(X<:A).
    However, intersection returns X for intersect(X,A). Since there
    appears to be a match there and A<B, ml_matches skips the match with B.
    The fix just requires dispatch tuples to be a subtype of a signature
    in order to match at all.
    
    (cherry picked from commit b167bc2)
    JeffBezanson authored and KristofferC committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    2d1c925 View commit details
    Browse the repository at this point in the history
  19. cluster manager fixes (#30172)

    * kill workers which don't launch properly
    
    * don't emit spurious error messages
    
    * document how to asynchronously launch workers
    
    (cherry picked from commit 121e814)
    bjarthur authored and KristofferC committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    aede024 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2018

  1. Fix #30006, getindex accessing fields that might not exist (#30405)

    * Fix #30006, range getindex accessing fields that might not exist
    * Add tests for #30006
    
    (cherry picked from commit 64133f6)
    raghav9-97 authored and KristofferC committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    e4a7db2 View commit details
    Browse the repository at this point in the history
  2. Fix method ambiguities in SparseArrays (#30120)

    * Remove unused struct CapturedScalars
    
    * Fix method ambiguities in SparseArrays
    
    * Fix HigherOrderFns._copy(f)
    
    (cherry picked from commit f10530e)
    tkf authored and KristofferC committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    fb28ab4 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2019

  1. Fix #20409: rank for sparse matrices. (#30415)

    (cherry picked from commit f36ace9)
    ViralBShah authored and KristofferC committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    7a7f552 View commit details
    Browse the repository at this point in the history
  2. Fix sparse cholesky to return Vector when the RHS is a Vector (#30416)

    Fixes #28985
    
    (cherry picked from commit b451001)
    raghav9-97 authored and KristofferC committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    e3af2c1 View commit details
    Browse the repository at this point in the history
  3. spmatmul sparse matrix multiplication - performance improvements (#30372

    )
    
    * General performance improvements for sparse matmul
    Details for the polyalgorithm are in: #30372
    
    (cherry picked from commit fae262c)
    KlausC authored and KristofferC committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    7d63456 View commit details
    Browse the repository at this point in the history
  4. Fixed sprand for dimensions of unusual integer type (#30516)

    Fixes #30502
    
    (cherry picked from commit 2ab1405)
    raghav9-97 authored and KristofferC committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    8c2ef25 View commit details
    Browse the repository at this point in the history
  5. Add custom deserialize method for UmfpackLU to avoid memory leak (#30425

    )
    
    Fixes #15450
    
    (cherry picked from commit 356ceee)
    andreasnoack authored and KristofferC committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    7542c72 View commit details
    Browse the repository at this point in the history
  6. Fix performance of broadcast and collect with Union{T, Missing}

    Use the same pattern as in collect_to_with_first! (which is used when size is known).
    
    (cherry picked from commit 184fbc4)
    nalimilan authored and KristofferC committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    bb23a90 View commit details
    Browse the repository at this point in the history
  7. gf: fix jl_isa_compileable_sig again (#30458)

    The last attempts were pretty good, but still missed a lot.
    But this is what you find when you actually try to test it.
    This is not too important, but it can reduce compilation
    performance in some case, so it is not ideal.
    
    (cherry picked from commit 76e7421)
    vtjnash authored and KristofferC committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    7bbc99a View commit details
    Browse the repository at this point in the history
  8. fix lambda-optimize-vars! with complex assignment RHSs (#30564)

    fixes #30563
    
    (cherry picked from commit 84a83ab)
    JeffBezanson authored and KristofferC committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    0bd12d0 View commit details
    Browse the repository at this point in the history
  9. Add the scaled identity matrix to a random matrix to avoid getting a …

    …singular matrix (#30576)
    
    Fix #30572
    
    (cherry picked from commit 4d8a968)
    ViralBShah authored and KristofferC committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    d7ad4bd View commit details
    Browse the repository at this point in the history
  10. Use XCode 8.3 for macOS on Travis (#30599)

    This corresponds to macOS 10.12 Sierra. XCode 8 covers El Capitan and
    Sierra, so if Travis is giving us XCode 8.x for x < 3, we're on El Cap.
    Homebrew supports only three versions of macOS at a time, which means
    that El Cap (10.11) is no longer support. This is likely why our Mac
    builds are trying to build GCC from source; a bottle might not be
    available.
    
    (cherry picked from commit 862fe08)
    ararslan authored and KristofferC committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    dc6994d View commit details
    Browse the repository at this point in the history
  11. fix typo in string search api docs (#30600)

    (cherry picked from commit a25945a)
    ashleysommer authored and KristofferC committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    90ba684 View commit details
    Browse the repository at this point in the history
  12. Make sure to call jl_islayout_inline() even in the case assertion is …

    …deactivated (#30615)
    
    (cherry picked from commit 2931072)
    petershintech authored and KristofferC committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    d839fe0 View commit details
    Browse the repository at this point in the history
  13. faster circshift! for SparseMatrixCSC (#30317)

    * implement circshift! for SparseMatrixCSC
    
    * factor helper function shifter!, implement efficient circshift! for SparseVector
    
    * add some @inbounds for improved performance
    
    * remove allocations completely, giving a large improvement for small matrices
    
    * some renaming to avoid polluting the module namespace
    
    * remove useless reallocation and fix bug with different in/out types, better tests
    
    * avoid action if iszero(r) and/or iszero(c), move sparse vector shifting helpers to sparsevector.jl
    
    * Make shift amounts deterministic in tests, move sparse vector tests into sparsevector.jl
    
    * comment fix
    
    * for some reason, copy!(a::SparseVector, b::SparseVector) does not work
    
    (cherry picked from commit 94993e9)
    abraunst authored and KristofferC committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    8ee59bc View commit details
    Browse the repository at this point in the history
  14. fix #30643, correctly propagate iterator traits through Stateful (#30644

    )
    
    (cherry picked from commit 21dfef3)
    denizyuret authored and KristofferC committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    543cf24 View commit details
    Browse the repository at this point in the history
  15. Fix SROA confusing new and old nodes

    SROA was accidentally treating a pending node as old and thus
    getting the wrong type when querying the predecessor. As a result
    it thought one of the paths was unreachable causing undefined data
    to be introduced on that path (generally the `1.0` that happened to
    already be in register).
    
    Fix #29983
    
    (cherry picked from commit da0179c)
    Keno authored and KristofferC committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    ba9d981 View commit details
    Browse the repository at this point in the history
  16. Defensively fix patterns similar to #29983

    I don't have concrete tests for these, but it looks like
    they all need the `is_old` predicate for what they're doing,
    so switch those over also while we're at it.
    
    (cherry picked from commit 34f7a4a)
    Keno authored and KristofferC committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    28ca40c View commit details
    Browse the repository at this point in the history
  17. string doc clarifications

    Clarify that `firstindex(str)` should always be `1` for any `AbstractString`, as mentioned by @StefanKarpinski [here](#26133 (comment)).
    
    Also reference `prevind` and `eachindex`.
    
    Also introduce the "code unit" terminology and mention the `codeunit` functions.
    
    (cherry picked from commit 3b6773d)
    stevengj authored and KristofferC committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    cb77cc3 View commit details
    Browse the repository at this point in the history
  18. string docs: clarify handling of overlong and too-high sequences

    (cherry picked from commit 8b45c9c)
    StefanKarpinski authored and KristofferC committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    bac9350 View commit details
    Browse the repository at this point in the history
  19. Fix use counts for mutable struct SROA

    PR #28478 moved the computation of the use counts before the finish call.
    to fix #28444. However, the early parts of the finish call fixes up phi
    node arguments, which fail to get counted if we look at use counts before
    that fixup is performed. This causes #30594 where the only non-trivial use
    is on the backedge of the phi and would thus incorrectly fail to get accounted
    for. Fix that by taking the use count after phi fixup but before dce.
    
    (cherry picked from commit f8f2045)
    Keno authored and KristofferC committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    da5d637 View commit details
    Browse the repository at this point in the history
  20. llvm: fix target triple (#30554)

    broken by their move to cmake causing a switch away from the standard --host/--build autoconf
    
    fix #28046
    
    (cherry picked from commit 041c214)
    vtjnash authored and KristofferC committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    f487cf3 View commit details
    Browse the repository at this point in the history