Mark aarch64 as BINARY=64 #31399
Closed
Mark aarch64 as BINARY=64 #31399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This opts us in to things like automatically building `openblas64_.so` on `aarch64` systems, which seems more consistent.
staticfloat
force-pushed
the
sf/binary64_aarch64
branch
from
13f8eb6
to
2b98f71
Compare
ararslan
approved these changes
Mar 19, 2019
ararslan
requested changes
Mar 19, 2019
Co-Authored-By: staticfloat <[email protected]>
ararslan
approved these changes
Mar 19, 2019
|
Okay looks like aarch64 doesn't actually support ILP64 at all. Weird. I better update my OpenBLAS builder to name things correctly then. (no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This opts us in to things like automatically building
openblas64_.soonaarch64systems, which seems more consistent. I think this makes sense, please someone correct me if it doesn't.