Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BINARY=64 not set on aarch64 #39612

Closed
staticfloat opened this issue Feb 11, 2021 · 7 comments · Fixed by #40265
Closed

BINARY=64 not set on aarch64 #39612

staticfloat opened this issue Feb 11, 2021 · 7 comments · Fixed by #40265
Labels
building Build system, or building Julia or its dependencies system:arm ARMv7 and AArch64
Milestone
1.7

Comments

@staticfloat
Copy link
Sponsor Member

I'm not certain if this is an unintentional oversight or something more profound, but our Makefile system does not set BINARY=64 on aarch64. This, in turn, causes OpenBLAS to be built (from source) as an LP64 (e.g. not an ILP64) build, which in turn causes us to build OpenBLAS as LP64 in Yggdrasil, which is not in line with our other 64-bit platforms such as x86_64 and powerpc64le.

I think we probably want to build OpenBLAS as ILP64 and set BINARY=64 on aarch64.
@staticfloat staticfloat added building Build system, or building Julia or its dependencies system:arm ARMv7 and AArch64 labels Feb 11, 2021
@staticfloat staticfloat added this to the 1.7 milestone Feb 11, 2021
@staticfloat
Copy link
Sponsor Member Author

Pinging a randomized subset of the linear algebra crew to see if there is any reason ILP64 might be disabled on aarch64.

@ViralBShah @andreasnoack @simonbyrne

@simonbyrne
Copy link
Contributor

Need to contact this guy: #31399

@staticfloat
Copy link
Sponsor Member Author

I knew there was a reason I pinged you Simon.

@ViralBShah
Copy link
Member

Yeah, we should probably go to ILP64 on aarch64. It will also require a bunch of BB stuff to be rebuilt.

@giordano giordano mentioned this issue Feb 14, 2021
Merged
@matbesancon
Copy link
Contributor

So this will be blocking #39436 if I understand correctly?

@ViralBShah
Copy link
Member

#39455 turns on ILP64 BLAS for aarch64, and passes all tests, so this does not block #39436 (surprisingly). I do wonder if BINARY=64 should be turned on as well (assuming -m64 can be accepted by gcc/clang on aarch64).

@rgobbel rgobbel mentioned this issue Mar 1, 2021
Closed
ViralBShah added a commit that referenced this issue Mar 30, 2021
@ViralBShah
Use BINARY=64 on aarch64
5f9e7ed 
Fix #39612
@ViralBShah ViralBShah mentioned this issue Mar 30, 2021
Merged
ViralBShah added a commit that referenced this issue Mar 30, 2021
@ViralBShah
Use BINARY=64 on aarch64 (#40265)
3f4bbae 
Fix #39612
@ViralBShah
Copy link
Member

-m64 is not accepted by GCC on arm. So nothing else to be done here.

ElOceanografo pushed a commit to ElOceanografo/julia that referenced this issue May 4, 2021
@ViralBShah @ElOceanografo
Use BINARY=64 on aarch64 (JuliaLang#40265)
4251d66 
Fix JuliaLang#39612
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this issue May 9, 2021
@ViralBShah @antoine-levitt
Use BINARY=64 on aarch64 (JuliaLang#40265)
ca0962e 
Fix JuliaLang#39612
johanmon pushed a commit to johanmon/julia that referenced this issue Jul 5, 2021
@ViralBShah @johanmon
Use BINARY=64 on aarch64 (JuliaLang#40265)
604dea7 
Fix JuliaLang#39612
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
building Build system, or building Julia or its dependencies system:arm ARMv7 and AArch64
Projects
None yet
Milestone
1.7
Development

Successfully merging a pull request may close this issue.

Use BINARY=64 on aarch64 JuliaLang/julia
4 participants
@staticfloat @ViralBShah @simonbyrne @matbesancon