Add some broken tests for invalidation #35855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/worlds.jl
Outdated
|
|
||
| ## A case in which there is no intersection between signatures | ||
| ## A possibly relevant point is that the invalidated instance comes from | ||
| ## convert(::Type{T}, x) where {T>:Nothing} = convert(nonnothingtype_checked(T), x) |
There was a problem hiding this comment.
In this case nonnothingtype_checked(T) returns Union{}, so this calls convert(Union{}, ::String) which is ambiguous, so hopefully it's just another case of the ambiguity issue.
|
Broken I assume means over-aggressive and not wrong? I'm intending to pick up work on that now, and see how that goes with the internals. |
Right. I just meant they were |
timholy
force-pushed
the
teh/broken_invalidation_tests
branch
from
916ebc2
to
6407c1f
Compare
timholy
force-pushed
the
teh/broken_invalidation_tests
branch
from
6407c1f
to
dfe2fc9
Compare
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that Jeff already has code to fix some of the invalidation issues, I'm trying to wrap up my work on this topic for the time being. I think this distills most of the triggers for the weird cases I found while writing JuliaLang/www.julialang.org#794.
There are just
threesix@test_brokens here, and obviously the goal would be to turn these into@tests. But I know that writing tests takes time, and I had a lot of material to work with, so I figured this would be a useful head start.