Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make == definition conditional #6

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Make == definition conditional #6

merged 1 commit into from
Jun 8, 2020

Conversation

timholy
Copy link
Owner

@timholy timholy commented Jun 8, 2020

Julia nightly now has this method (JuliaLang/julia#35855), so we should check for it before defining it.

@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   93.67%   93.67%           
=======================================
  Files           3        3           
  Lines         158      158           
=======================================
  Hits          148      148           
  Misses         10       10           
Impacted Files Coverage Δ
src/MethodAnalysis.jl 93.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85a2715...7195a67. Read the comment docs.

@timholy timholy merged commit 15d598f into master Jun 8, 2020
@timholy timholy deleted the teh/nightly_warning branch June 8, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant