Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "🤖 Bump the Downloads stdlib from 5f1509d to dbb0625" #42848

Closed
wants to merge 1 commit into from
Closed

Revert "🤖 Bump the Downloads stdlib from 5f1509d to dbb0625" #42848

wants to merge 1 commit into from

Conversation

KristofferC
Copy link
Sponsor Member

Reverts #42811

This broke Pkg: JuliaLang/Pkg.jl#2802 (comment)

@DilumAluthge
Copy link
Member

DilumAluthge commented Oct 29, 2021 •
edited
Loading

And reverting it will break the Downloads tests on Base Julia 😭

Instead of reverting the Downloads bump on Julia master, I would suggest:

  1. On the Downloads.jl repo, revert:
  2. Bump Downloads again on Julia master.

@StefanKarpinski @staticfloat What's the right course of action here?

@KristofferC
Copy link
Sponsor Member Author

Aha, I didn't know they were bundled in the same release. Then, this doesn't work.

@DilumAluthge
Copy link
Member

DilumAluthge commented Oct 29, 2021 •
edited
Loading

Aha, I didn't know they were bundled in the same release. Then, this doesn't work.

Let's revert just JuliaLang/Downloads.jl#151

JuliaLang/Downloads.jl#156

@DilumAluthge DilumAluthge deleted the revert-42811-BumpStdlibs/Downloads-dbb0625 branch October 29, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KristofferC @DilumAluthge