Improve backwards compatibility in sorting #47489
Conversation
|
@nanosoldier |
|
Your package evaluation job has completed - no new issues were detected. A full report can be found here. |
|
@nanosoldier |
| @@ -474,6 +474,7 @@ Characteristics: | |||
| (vanishingly rare for non-malicious input) | |||
| """ | |||
| const QuickSort = PartialQuickSort(missing, missing) | |||
| const QuickSortAlg = PartialQuickSort{Missing, Missing} # Exists for backward compatibility | |||
There was a problem hiding this comment.
I remember trying this but I think there was something it didn't handle. Might be wrong though...
|
Why retry these packages? They are tests that started passing on this PR. PkgEval also already retries nowadays, so it's not strictly necessary anymore to do so manually. |
I think because the content of the PR changed since the last run. |
|
Oh ok, carry on then! I was waiting for PkgEval to go idle so that I can upgrade it, hence me looking at the logs 🙂 |
|
Your package evaluation job has completed - no new issues were detected. A full report can be found here. |
Fixup for #45222
This is not technically required as that dispatch system is undocumented and therefore internal. Nevertheless, it has zero runtime cost and might make some folks' lives easier.
See: https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/6b14101_vs_97ccb97/StatisticalGraphics.primary.log, for example
From @KristofferC's request on slack