Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve backwards compatibility in sorting #47489

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Improve backwards compatibility in sorting #47489

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0ddb7c
Improve backwards compatibility in sorting
LilithHafner Nov 8, 2022
bd3264c
whitespace
LilithHafner Nov 8, 2022
f5d4457
take a much simpler approach
Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions base/sort.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,7 @@ Characteristics:
(vanishingly rare for non-malicious input)
"""
const QuickSort = PartialQuickSort(missing, missing)
const QuickSortAlg = PartialQuickSort{Missing, Missing} # Exists for backward compatibility
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember trying this but I think there was something it didn't handle. Might be wrong though...


"""
MergeSort
Expand Down