-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MvNormal #160
Update MvNormal #160
Conversation
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
==========================================
+ Coverage 37.26% 43.05% +5.78%
==========================================
Files 29 30 +1
Lines 585 583 -2
==========================================
+ Hits 218 251 +33
+ Misses 367 332 -35
Continue to review full report at Codecov.
|
I think it's good! This test passes: @testset "MvNormal" begin
Q,R = qr(randn(4,2))
# Make sure `R` has a positive diagonal
D = Diagonal(sign.(diag(R)))
Q = Matrix(Q) * D
R = D * R
z = randn(2)
ℓ = logpdf(MvNormal((σ= R,)),z)
@test ℓ ≈ Dists.logpdf(Dists.MvNormal(R*R'),z)
@test ℓ ≈ logpdf(MvNormal((σ= Q*R,)),Q*z)
end But I broke a bunch of |
Hi @mschauer, Breakage shows Mitosis tests failing, but it looks like it's just a version bound issue. Can you have a look? This is part of a fix for a bug that was causing a big problem in Soss (cscherrer/Soss.jl#305) so I'm hoping to get it merged soon. If you don't get a chance today I'll go ahead and merge it as a major release. |
This PR makes simplifications to
MvNormal
, based on the newAffine
constructor in MeasureBase