Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #305 #306

Merged
merged 6 commits into from
Oct 18, 2021
Merged

Fixes #305 #306

merged 6 commits into from
Oct 18, 2021

Conversation

cscherrer
Copy link
Owner

@cscherrer cscherrer commented Oct 15, 2021

I think this fixes it. Note that it requires JuliaMath/MeasureTheory.jl#160, which isn't yet merged

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #306 (c55d430) into master (eb79e00) will increase coverage by 1.15%.
The diff coverage is n/a.

❗ Current head c55d430 differs from pull request most recent head d3e5f80. Consider uploading reports for the commit d3e5f80 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
+ Coverage   30.04%   31.19%   +1.15%     
==========================================
  Files          49       49              
  Lines        1225     1218       -7     
==========================================
+ Hits          368      380      +12     
+ Misses        857      838      -19     
Impacted Files Coverage Δ
src/Soss.jl 100.00% <ø> (ø)
src/primitives/basemeasure.jl 82.35% <ø> (ø)
src/primitives/logdensity.jl 78.12% <0.00%> (+44.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb79e00...d3e5f80. Read the comment docs.

@cscherrer cscherrer merged commit 7883dc5 into master Oct 18, 2021
@cscherrer cscherrer deleted the Fixes-305 branch October 18, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For(...) do i ... broken using Soss with [email protected] or later
1 participant