Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenBLAS] build 64 Aarch without special case #2465

Merged
merged 6 commits into from
Feb 17, 2021

Conversation

matbesancon
Copy link
Contributor

@matbesancon matbesancon commented Jan 28, 2021

Following JuliaLang/julia#39436, first attempt at building blas with 64 bits even on aarch64 without the special condition

@matbesancon
Copy link
Contributor Author

I'm not sure if something special should be made to trigger the various builds here?

O/OpenBLAS/common.jl Outdated Show resolved Hide resolved
Co-authored-by: John M. Kuhn <[email protected]>
@giordano
Copy link
Member

I'm not sure if something special should be made to trigger the various builds here?

Yes, you need to touch all the files O/OpenBLAS/OpenBLAS*@x.y.z/build_tarballs.jl for the version x.y.z you want to rebuild (0.3.13?)

@ViralBShah
Copy link
Member

By touch, I assume you mean make at least a whitespace change, right? Would be nice to get openblas to 64-bit on aarch64. Will need changes in various other packages as well - and it will be nice to get it done.

@giordano
Copy link
Member

There is also OpenBLAS high count.

Related to aarch64 OpenBLAS there is JuliaLang/julia#39612, too

@ViralBShah
Copy link
Member

ViralBShah commented Feb 15, 2021

I think OpenBLAS high count is not crucial at this point (since it cannot be automatically used anyways). I presume this is in preparation of using BINARY=64 on Julia base for aarch64.

@matbesancon
Copy link
Contributor Author

woops, should not have touched HighCount 3.12?

@giordano
Copy link
Member

The version is wrong, but it isn't good it's failing....

@matbesancon
Copy link
Contributor Author

also it's failing on x86, so independently from the change of the PR :/

@ViralBShah ViralBShah changed the title build 64 Aarch without special case [OpenBLAS] build 64 Aarch without special case Feb 15, 2021
@giordano
Copy link
Member

Provided that you still need to edit 0.3.13 instead of 0.3.12, I'm very confused by the error: it looks like we're hitting the bug which was supposedly fixed by #2415 😕

@matbesancon
Copy link
Contributor Author

Is there a direction to investigate in particular? Not sure I can be particularly helpful

@staticfloat
Copy link
Member

@giordano didn't we just add some compiler header fixes for an AVX512 bug?

Googling this error message turns up this: https://gcc.gnu.org/legacy-ml/gcc-patches/2018-01/msg01962.html

@giordano
Copy link
Member

Yes #2465 (comment)

@staticfloat
Copy link
Member

Excellent. In that thread:

Note this patch doesn't apply to GCC 6 as _mm512_abs_pd and _mm512_mask_abs_pd are not defined

@giordano
Copy link
Member

But this is failing with libgfortran 4 and 6, so not GCC 6

@giordano
Copy link
Member

giordano commented Feb 16, 2021

I mean, one possibility is that I built the wrong GCC..... But JuliaPackaging/BinaryBuilderBase.jl#101 (comment) would indicate that it isn't the case

@staticfloat
Copy link
Member

I believe this is an OpenBLAS bug. I can confirm locally that 0.3.12 breaks and 0.3.13 works, so I say we just build 0.3.13 and use that.

@giordano
Copy link
Member

Good to go?

@staticfloat staticfloat merged commit d5d4069 into JuliaPackaging:master Feb 17, 2021
@staticfloat
Copy link
Member

Note that this version is going to be incompatible with, like, everything because the aarch64 build is now ILP64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants