Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LASzip] Bump to also generate Mac M1 builds #5345

Merged
merged 6 commits into from
Aug 24, 2022

Conversation

evetion
Copy link
Contributor

@evetion evetion commented Aug 23, 2022

No description provided.

@giordano giordano changed the title Bump to also generate Mac M1 builds [LASzip] Bump to also generate Mac M1 builds Aug 24, 2022
@giordano
Copy link
Member

#2763

There is a large demand to build packages for the "experimental" platforms aarch64-apple-darwin and armv6l-linux-*, but there are two NON-NEGOTIABLE constraints

  1. the JLL package must require at least Julia v1.6, because only Julia v1.6+ is able to deal with the presence of these platforms in the Artifacts.toml file
  2. most existing packages are marked as compatible with Julia v1.0, but as a consequence of the point 1 above if we want to rebuild an existing package for the new platform the generated JLL package must have a new version number. No exceptions whatsoever to this rule, otherwise we'll break the ecosystem for Julia v1.5-

In particular, see point 2

@@ -3,7 +3,7 @@
using BinaryBuilder, Pkg

name = "LASzip"
version = v"3.4.3"
version = v"3.4.3-1.6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh, no, you have to stick to X.Y.Z only. I guess I'm going to prohibit anything else completely, since this is just the second attempt in one day: #5344 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for making you sigh 😓. I was wondering how to "break" away from following the exact version of the underlying library. I will set it to `v"3.4.3000" for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a PkgVersion (pv"1.2.3") or similar to enforce such things?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants