Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LASzip] Bump to also generate Mac M1 builds #5345

Merged
merged 6 commits into from
Aug 24, 2022
Merged

[LASzip] Bump to also generate Mac M1 builds #5345

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6ad3b86
Bump to also generate Mac M1 builds
evetion Aug 23, 2022
9e75982
No experimental platforms
evetion Aug 24, 2022
087e6b4
Merge branch 'master' into patch-4
evetion Aug 24, 2022
1c1278d
Set julia_compat
evetion Aug 24, 2022
f460560
Set new version number
evetion Aug 24, 2022
a2139eb
Stick version to X.Y.Z
evetion Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions L/LASzip/build_tarballs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
using BinaryBuilder, Pkg

name = "LASzip"
version = v"3.4.3"
version = v"3.4.3-1.6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh, no, you have to stick to X.Y.Z only. I guess I'm going to prohibit anything else completely, since this is just the second attempt in one day: #5344 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for making you sigh 😓. I was wondering how to "break" away from following the exact version of the underlying library. I will set it to `v"3.4.3000" for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a PkgVersion (pv"1.2.3") or similar to enforce such things?


# Collection of sources required to complete build
sources = [
Expand All @@ -25,6 +25,7 @@ cmake -DCMAKE_INSTALL_PREFIX=$prefix -DCMAKE_CXX_FLAGS="-std=c++11" -DCMAKE_TOOL
cmake --build . --target install --config Release
"""


# These are the platforms we will build for by default, unless further
# platforms are passed in on the command line
platforms = supported_platforms()
Expand All @@ -40,4 +41,4 @@ dependencies = Dependency[
]

# Build the tarballs, and possibly a `build.jl` as well.
build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies)
build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies; julia_compat="1.6")