make tick finding more compatible with Float64 (#161)

* adjust limit for fallback_ticks * fix Integer inputs * fix typo and add test * Fix formatting * Remove extra newline --------- Co-authored-by: Anshul Singhvi <[email protected]>
JuliaPlots · Mar 5, 2024 · c03d790 · c03d790
1 parent 3af0e0e
commit c03d790
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/ticks.jl b/src/ticks.jl
@@ -154,7 +154,10 @@ function optimize_ticks(
     span_buffer = nothing,
     scale = nothing,
 ) where {T}
-    x_min ≈ x_max && return fallback_ticks(x_min, x_max, k_min, k_max, strict_span)
+    rtol = T <: AbstractFloat ? 1000.0 * eps(T) : Base.rtoldefault(x_min, x_max, 0)
+    if isapprox(x_min, x_max, rtol = rtol)
+        return fallback_ticks(x_min, x_max, k_min, k_max, strict_span)
+    end
 
     F = float(T)
     Qv = F[q[1] for q ∈ Q]

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -119,6 +119,9 @@ end
 @testset "ticks" begin
     @test optimize_ticks(-1, 2) == ([-1.0, 0.0, 1.0, 2.0], -1.0, 2.0)
 
+    # check if ticks still generate if max - min << abs(min) (i.e. for Float64 ranges)
+    @test optimize_ticks(1e11 - 1, 1e11 + 2) == (1e11 .+ (-1:2), 1e11 - 1.0, 1e11 + 2.0)
+
     @testset "dates" begin
         dt1, dt2 = Dates.value(DateTime(2000)), Dates.value(DateTime(2100))
         @test optimize_datetime_ticks(dt1, dt2) == (