Make tick finding more compatible with Float64 #161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on MakieOrg/Makie.jl#3663 I noticed that ticks are broken for
1e9 .+ (1:10)
:In this case PlotUtils switches to
fallback_ticks
as9 / 1e9 < sqrt(eps(Float64)) ~ 1e-8
and we get(min, 0.5 * (max + min), max)
. Our pretty-string functions then round those values to integers, I assume.To avoid the PlotUtils part of the problem I think just adjusting the rtol is enough. With
rtol = 1000.0 * eps(T)
the tolerance should be about the same for Float32 and 1e-13 for Float64. With that the plot becomes: