Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force an old version of the Kaleido C library for windows tests #36

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

disberd
Copy link
Member

@disberd disberd commented Dec 11, 2023

It seems that many people face problems with kaleido on windows hanging:

The suggestion in the issues in the main Kaleido repository above was to downgrade the kaleido library to 0.1 in windows to make this work, and preliminary tests seem to validate this also from Julia.

It is not necessary to downgrade PlotlyKaleido itself, but is sufficient to introduce in the Project/environment the Kaleido_jll package tagged to the 0.1 version.
This seems to fix the tests and should also be a way of fixing the PlotlyKaleido library on windows machines

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bcfb514) 88.62% compared to head (38a7910) 89.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   88.62%   89.41%   +0.78%     
==========================================
  Files          12       12              
  Lines         255      255              
==========================================
+ Hits          226      228       +2     
+ Misses         29       27       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@disberd disberd merged commit 8c46e64 into main Dec 11, 2023
5 checks passed
@disberd disberd deleted the windows-kaleido-test branch December 11, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant