Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docfix; close issue #357 #358

Merged
merged 6 commits into from
Jun 9, 2020
Merged

Docfix; close issue #357 #358

merged 6 commits into from
Jun 9, 2020

Conversation

jverzani
Copy link
Collaborator

@jverzani jverzani commented Jun 5, 2020

Close #357 by using Documenter and jldoctest for the tutorial and introduction documents.

  • Need to remove Examples directory

  • Need assistance setting up keys for JuliaPy

@jverzani
Copy link
Collaborator Author

jverzani commented Jun 5, 2020

Hi @ararslan . You were very helpful setting up a deployment key for Polynomials.jl, do you think you could help again? In following the instructions produced by DocumenterTools.genkeys I got stuck adding a public key. I also can't add to https://travis-ci.com/JuliaPy/SymPy.jl/settings, but I think https://travis-ci.com/jverzani/SymPy.jl/settings will work for that. Sorry to take your time, but I'm admittedly new to using Documenter, and think I need some assistance with this part.

@ararslan
Copy link
Member

ararslan commented Jun 5, 2020

I'd be happy to help but in this case I can't, since, like you, I don't have owner-level privileges in the organization. That's required to access repository settings and add the necessary deployment keys. @stevengj, could you perhaps take care of this?

@jverzani
Copy link
Collaborator Author

jverzani commented Jun 5, 2020

Thanks for the response!

@stevengj
Copy link
Member

stevengj commented Jun 6, 2020

I've changed @jverzani and @ararslan to have Owner access.

@jverzani
Copy link
Collaborator Author

jverzani commented Jun 6, 2020

Thanks!

@ararslan
Copy link
Member

ararslan commented Jun 8, 2020

@jverzani, looks like you added a deploy key for Documenter. Are you all set here then or is there anything else I can help with?

@jverzani
Copy link
Collaborator Author

jverzani commented Jun 8, 2020

@ararslan Thanks for following up. I thing I'm good to go. Your help was very much appreciated.

@jverzani jverzani merged commit 382a805 into JuliaPy:master Jun 9, 2020
@jverzani jverzani deleted the docfix branch June 9, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linsolve fails
3 participants