Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2-arg hash #521

Closed
wants to merge 1 commit into from
Closed

add 2-arg hash #521

wants to merge 1 commit into from

Conversation

jverzani
Copy link
Collaborator

@jverzani jverzani commented Sep 19, 2023

A partial means to close #520 PR #522 provides a solution that does not depend on any change to PyCall.

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05% ⚠️

Comparison is base (9aa9a39) 55.92% compared to head (fba312f) 55.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
- Coverage   55.92%   55.87%   -0.05%     
==========================================
  Files          20       20              
  Lines        1250     1251       +1     
==========================================
  Hits          699      699              
- Misses        551      552       +1     
Files Changed Coverage Δ
src/types.jl 34.00% <0.00%> (-0.70%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jverzani
Copy link
Collaborator Author

Did this differently

@jverzani jverzani closed this Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overload for hash(::Sym, ::UInt64) missing
2 participants