Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2-arg hash leveraging PyCall and PythonCall approaches #522

Merged
merged 11 commits into from
Sep 24, 2023

Conversation

jverzani
Copy link
Collaborator

This closes #520 leveraging code from both PyCall and PythonCall.

It also addresses https://discourse.julialang.org/t/sympy-sym-s-as-keys-in-dicts/103995

@jverzani jverzani mentioned this pull request Sep 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10% 🎉

Comparison is base (9aa9a39) 55.92% compared to head (6a5482d) 56.02%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #522      +/-   ##
==========================================
+ Coverage   55.92%   56.02%   +0.10%     
==========================================
  Files          20       20              
  Lines        1250     1253       +3     
==========================================
+ Hits          699      702       +3     
  Misses        551      551              
Files Changed Coverage Δ
src/assumptions.jl 18.40% <100.00%> (ø)
src/types.jl 38.46% <100.00%> (+3.76%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jverzani jverzani merged commit 95178f8 into JuliaPy:master Sep 24, 2023
10 checks passed
@jverzani jverzani deleted the issue_520_alt branch September 24, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overload for hash(::Sym, ::UInt64) missing
2 participants