Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pkg package and compat for it to packages #92580

Closed
wants to merge 1 commit into from

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Oct 1, 2023

No description provided.

@vchuravy
Copy link
Member Author

vchuravy commented Oct 2, 2023

Ah this is missing the "Pkg package" part.

@@ -6,6 +6,7 @@ julia = "1"

["0-0.2.0"]
Configurations = "0.3-0.15"
Pkg = "1"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know exactly what changes this is supposed to make, but only updating compat for the oldest version seems unreasonable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be consistent?

Only ["0-0.2.0"] has a dependency on Pkg.

vchuravy@odin ~/s/G/A/AbInitioSoftwareBase  cat Deps.toml 
[0]
Configurations = "5218b696-f38b-4ac9-8b61-a12ec717816d"
IsURL = "ceb4388c-583f-448d-bb30-00b11e8c5682"
JSON = "682c06a0-de6a-54ab-a142-c8b1cf79cde6"
YAML = "ddb6d928-2868-570f-bddf-ab3f9cf99eb6"

["0-0.2.0"]
Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"

["0.2.1-0"]
TOML = "fa267f1f-6049-4f14-aa54-33bafae1ed76"

["0.4-0.5"]
MPICH_jll = "7cb0a576-ebde-5e09-9194-50597f1243b4"

["0.5-0"]
Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"

["0.6.5-0"]
Preferences = "21216c6a-2e73-6563-6e65-726566657250"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks. That was the connection I was missing.

@github-actions github-actions bot added the stale label Nov 2, 2023
@JuliaRegistries JuliaRegistries deleted a comment from github-actions bot Nov 2, 2023
@DilumAluthge DilumAluthge removed the stale label Nov 2, 2023
@KristofferC
Copy link
Member

I think LazyArtifacts have to be made upgradable first.

@vchuravy
Copy link
Member Author

vchuravy commented Nov 2, 2023

Yeah maybe it's time to redo #92622

Copy link
Contributor

github-actions bot commented Dec 4, 2023

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

@github-actions github-actions bot added the stale label Dec 4, 2023
Copy link
Contributor

This pull request has been inactive for more than 30 days and has automatically been closed. Feel free to register your package or version again once you fix the AutoMerge issues. [noblock]

@github-actions github-actions bot closed this Dec 12, 2023
@github-actions github-actions bot deleted the vc/add_pkg_to_registry branch December 12, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants