Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compat for LazyArtifacts #92622

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Update compat for LazyArtifacts #92622

merged 1 commit into from
Nov 9, 2023

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Oct 2, 2023

  • Update LazyArtifacts compat
  • register new version

Copy link
Contributor

github-actions bot commented Nov 2, 2023

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

@vchuravy
Copy link
Member Author

vchuravy commented Nov 2, 2023

@DilumAluthge My preferred plan of action is to run the CompatStdlibUpdater for all stdlibs and then register the stdlibs one by one.
I think one of the challenges is what do we want to use as the commit for the 1.11.0 registration.

@github-actions github-actions bot removed the stale label Nov 3, 2023
@vchuravy vchuravy changed the title Make LazyArtifacts.jl an upgradeable stdlib Update compat for LazyArtifacts Nov 9, 2023
@vchuravy vchuravy marked this pull request as ready for review November 9, 2023 02:53
@vchuravy vchuravy merged commit 3ac0066 into master Nov 9, 2023
9 checks passed
@vchuravy vchuravy deleted the vc/update_lazyartifact branch November 9, 2023 02:57
@giordano
Copy link
Member

I think this should have just used "1" everywhere.

@DilumAluthge
Copy link
Member

Tbh it probably should have used <0.0.1, 1 everywhere.

@giordano
Copy link
Member

There's no version 0.0.0 in the registry, only 1.3 and 1.11

@DilumAluthge
Copy link
Member

When you do e.g. Pkg.test() in Julia 1.3, Pkg will set the version numbers of all stdlibs to 0.0.0.

@giordano
Copy link
Member

But LazyArtifacts isn't a stdlib in Julia v1.3, is it?

@DilumAluthge
Copy link
Member

The bug can still show up in later Julia versions. In e.g. Julia 1.8 and 1.9, if you do Pkg operations during your test suite, then you (and all of your recursive dependencies) need to have <0.0.1 in the stdlib compat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants