Improve API and documentation for SpatialInertia construction. #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkoolen
changed the title
|
CC: @Symplectomorphism, sorry it took so long. |
|
@rdeits, could I ask you to double check the |
tkoolen
force-pushed
the
tk/inertia-updates
branch
from
f510b39
to
5aca52a
Compare
Add warning to SpatialInertia doc. Improve show method for SpatialInertia. SpatialInertia: add constructor doc, add convenience kwarg constructor, update rand method to use new constructor. Add test for new SpatialInertia constructor. Also add a `moment` keyword argument to the SpatialInertia constructor. Use kwarg constructor in more places.
tkoolen
force-pushed
the
tk/inertia-updates
branch
from
5aca52a
to
73e97b6
Compare
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
==========================================
+ Coverage 99.27% 99.53% +0.25%
==========================================
Files 38 38
Lines 1788 2770 +982
==========================================
+ Hits 1775 2757 +982
Misses 13 13
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
==========================================
+ Coverage 99.27% 99.53% +0.25%
==========================================
Files 38 38
Lines 1788 2770 +982
==========================================
+ Hits 1775 2757 +982
Misses 13 13
Continue to review full report at Codecov.
|
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #520. @togo59, I hope this will clarify things and improve usability.