Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DCISolver for Krylov 0.8 #98

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

amontoison
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #98 (9f1ba47) into main (c226013) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   79.60%   79.60%           
=======================================
  Files          10       10           
  Lines         559      559           
=======================================
  Hits          445      445           
  Misses        114      114           
Impacted Files Coverage Δ
src/param_struct.jl 73.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c226013...9f1ba47. Read the comment docs.

@tmigot
Copy link
Member

tmigot commented Apr 7, 2022

I believe the doc fails because also uses JSOSolvers, JuliaSmoothOptimizers/JSOSolvers.jl#115

1 similar comment
@tmigot
Copy link
Member

tmigot commented Apr 7, 2022

I believe the doc fails because also uses JSOSolvers, JuliaSmoothOptimizers/JSOSolvers.jl#115

@tmigot tmigot assigned tmigot and unassigned tmigot Apr 7, 2022
@tmigot tmigot self-requested a review April 7, 2022 12:19
@tmigot
Copy link
Member

tmigot commented Apr 8, 2022

Can you update also the Project.toml in the docs?

@tmigot
Copy link
Member

tmigot commented Apr 8, 2022

the doc is failing because of CaNNOLeS now... JuliaSmoothOptimizers/CaNNOLeS.jl#45

@amontoison amontoison merged commit 22e9666 into JuliaSmoothOptimizers:main Apr 8, 2022
@amontoison amontoison deleted the update_krylov branch April 8, 2022 22:36
@amontoison
Copy link
Member Author

You can do a new release @tmigot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants